[rush] Refactor rush-sdk to expose a loader API. #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
apostolisms,
D4N14L,
octogonz and
sachinjoseph
as code owners
dmichon-msft
reviewed
Feb 8, 2022
|
|
||
| installAndRunRushStderrContent = installAndRuhRushProcess.stderr; | ||
| if (installAndRuhRushProcess.status !== 0) { | ||
| throw new Error(`The ${RUSH_LIB_NAME} package failed to install`); |
There was a problem hiding this comment.
This error gets immediately discarded by the catch below.
dmichon-msft
reviewed
Feb 8, 2022
dmichon-msft
reviewed
Feb 8, 2022
Co-authored-by: David Michon <[email protected]>
chengcyber
reviewed
Feb 12, 2022
| installAndRunRushJSPath, | ||
| '--help' | ||
| ]); | ||
| terminal.write(installAndRuhRushProcess.stdout); |
There was a problem hiding this comment.
Note: rush --help lists all rush commands information, but the idea is just trigger the install-run logic behind. I can see this stdout would be pretty annoying, so it's intentionaly removed in original implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the design in #3209
How it was tested
Moved the test to its own project and verified that it still works.